Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A NemoAction can outlive the NemoActionManager that connected to its "condition-changed" signal: actions are also referenced by the GtkActionGroups they are added to, and the manager itself is created per view, sidebar and window (nemo-view.c, nemo-places-sidebar.c,nemo-tree-sidebar.c) and finalized when those are destroyed.
The handler installed with g_signal_connect_swapped() is never dropped, so a later DBus owner change on a condition-gated action invokes the swapped callback with a destroyed manager.
Reproduce: open two Nemo windows, close one, then own the DBus name a custom action's condition watches:
Conditions=dbus com.example.DbusTest;
dbus-test-tool echo --session --name=com.example.DbusTest
With
G_SLICE=always-malloc MALLOC_PERTURB_=165 nemoso the freed manager's memory cannot look valid, every run crashes at the emit above. After the patch the same sequence is clean and the remaining window's menu stillupdates.