Repository navigation
Conversation
With a single item selected the status text starts with its name, so a name beginning with an RTL character made the whole line RTL (and an LTR name did the same in an RTL locale). Wrap the name in FSI...PDI and lead with an LRM/RLM for the UI direction, since Pango picks the paragraph direction from the first strong character even inside an isolate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
"%s" selectedstatus text took its direction from the file name, so a hebrew name flipped the whole line, and an english name did the same in an RTL locale. the name is now wrapped in FSI/PDI as suggested in the issue, plus an LRM or RLM for the UI direction in front, because from what i can tell pango still takes the first strong char inside the isolate when it picks the paragraph direction. Fixes #3542