Repository navigation
Conversation
clamp_ranges dropped ranges that start past the last page but still returned TRUE when none were left, so printing went on with zero ranges and read past the ranges array. It also counted the dropped ranges in n_pages_to_print. Skip them in the count and treat an empty result as an invalid selection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
printing a page past the end (like page 11 of a 10 page pdf) crashed.
clamp_rangesthrew the range away but still returned TRUE withn_rangesset to 0, so the print loop went on readingexport->rangespast its end. it now returns FALSE in that case, which shows the existing "Invalid page selection" warning, and dropped ranges no longer count towardsn_pages_to_print. Fixes #644