Repository navigation
Drop rmw_fastrtps_shared_cpp dependency - #287
Merged
Merged
Conversation
ros2/rmw_fastrtps#923 removed rmw_fastrtps_shared_cpp on rolling. Inline the GID and topic prefix helpers the Agent used from it, and depend explicitly on rcpputils and rmw/qos_profiles.h, which it used to provide transitively. Signed-off-by: David Laseca Perez <[email protected]>
Contributor
|
This pull request is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ros2/rmw_fastrtps#923 removed
rmw_fastrtps_shared_cpponrollingand made its headers private tormw_fastrtps_cpp. It is no longer released, sorosdep installfails onmicro_ros_agent, and the Agent stops building once the package is gone from the image.Changes
create_rmw_gidis defined locally ingraph_manager.cpp, it produces the same GID asrmw_fastrtps_cpp(the 16-byte GUID copied as is)rt/rq/rrtopic prefixes,_resolve_prefixand_strip_ros_prefix_if_existsare defined locally indemangle.cpprcpputilsandrmw/qos_profiles.hare now declared explicitly, both were used but the Agent only got them throughrmw_fastrtps_shared_cpprmw_fastrtps_shared_cpp/qos.hppincludes are removed