Skip to content

Drop rmw_fastrtps_shared_cpp dependency - #287

Merged
David-LP99 merged 1 commit into
rollingfrom
rolling-drop-fastrtps-shared
Nov 17, 2026
Merged

David-LP99 merged 1 commit into
rollingfrom
rolling-drop-fastrtps-shared

Conversation

@David-LP99

@David-LP99 David-LP99 commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Description

ros2/rmw_fastrtps#923 removed rmw_fastrtps_shared_cpp on rolling and made its headers private to rmw_fastrtps_cpp. It is no longer released, so rosdep install fails on micro_ros_agent, and the Agent stops building once the package is gone from the image.

Changes

  • create_rmw_gid is defined locally in graph_manager.cpp, it produces the same GID as rmw_fastrtps_cpp (the 16-byte GUID copied as is)
  • The rt/rq/rr topic prefixes, _resolve_prefix and _strip_ros_prefix_if_exists are defined locally in demangle.cpp
  • rcpputils and rmw/qos_profiles.h are now declared explicitly, both were used but the Agent only got them through rmw_fastrtps_shared_cpp
  • The unused rmw_fastrtps_shared_cpp/qos.hpp includes are removed

ros2/rmw_fastrtps#923 removed rmw_fastrtps_shared_cpp on rolling. Inline the
GID and topic prefix helpers the Agent used from it, and depend explicitly on
rcpputils and rmw/qos_profiles.h, which it used to provide transitively.

Signed-off-by: David Laseca Perez <[email protected]>
@mergify

mergify Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

This pull request is merged.

@EugenioCollado EugenioCollado left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@David-LP99
David-LP99 merged commit 5c71cde into rolling Nov 17, 2026
3 checks passed
@David-LP99
David-LP99 deleted the rolling-drop-fastrtps-shared branch November 17, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants