Repository navigation
reexec: fix flaky TestCommandContext on Windows - #282
Merged
Merged
Conversation
All TestCommandContext subtests use a context with a 100ms timeout,
but only the "context timeout" case needs it. On a slow CI runner
(seen on windows-2025), a reexec'd child that should succeed can take
longer than 100ms, the context expires, cmd.Cancel is called, and the
test fails with:
reexec_test.go:372: unexpected error: exec: canceling Cmd: test-error: the command was canceled (out: Hello test-reexec2
Only set the timeout for the test case that needs it.
Signed-off-by: Kir Kolyshkin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All TestCommandContext subtests use a context with a 100ms timeout, but only the "context timeout" case needs it. On a slow CI runner (seen on windows-2025 in #281), a reexec'd child that should succeed can take longer than 100ms, the context expires,
cmd.Cancelis called, and the test fails with:Only set the timeout for the test case that needs it.