Repository navigation
[Server] Include the request id in the error for an initialize request with a session ID - #758
Open
andre-schade wants to merge 1 commit into
Conversation
…t with a session ID Co-Authored-By: Claude Opus 5.5 <[email protected]>
andre-schade
requested review from
CodeWithKyrian,
Nyholm,
chr-hertel and
soyuka
as code owners
November 19, 2026 21:25
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #755
Protocol::resolveSession()answered aninitializerequest that comes with a session ID (e.g. a repeatedinitializeon STDIO) with an error withoutid. The spec requires error responses to carry the id of the request ("Error responses MUST include the same ID as the request they correspond to"), so the client could not correlate the error and waited for a timeout.This passes
self::findRequestId($message), like the other branches of the method already do. The existing test now also asserts the id.🤖 Generated with Claude Code