Repository navigation
[Client] Keep the listening stream tests from blocking on macOS - #760
Open
andre-schade wants to merge 1 commit into
Open
andre-schade wants to merge 1 commit into
andre-schade wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]>
andre-schade
requested review from
CodeWithKyrian,
Nyholm,
chr-hertel and
soyuka
as code owners
November 20, 2026 04:47
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS,
make testshangs inHttpTransportListenTest:testEventLargerThanOneReadIsHandledWithinOneCallandtestListenStreamReadIsBoundedPerCallwrite 20 KB and 90 KB to the server end of the socket pair before the client reads anything. A Unixstream_socket_pair()buffers only 8 KB on macOS (Linux buffers far more, so CI is green), so the blockingfwrite()never returns.The test helper now creates the pair with ext-sockets when it is loaded and raises
SO_SNDBUF/SO_RCVBUFto 1 MiB. Without ext-sockets, and on Windows, it falls back tostream_socket_pair()as before. With this,tests/Unit/Clientpasses on macOS (PHP 8.5): 1435 tests.Test-only change.
🤖 Generated with Claude Code