Repository navigation
Fix FastMCP Prometheus registry handling and hashed-tool CI - #459
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #451. Closes #460.
FastMCP HTTP metrics, tool metrics, and the scrape endpoint now use the configured Prometheus registry. The global registry remains the default. The optional in-progress gauge uses the configured registry and is shared across generated HTTP apps with matching gauge settings. The 2.x migration guide documents custom-registry scrapes.
The scheduled check exposed two test assumptions when FastMCP 4.2.0 added a
__prefix to hashed call names. Build aliases from FastMCP's call-name helper and assert the documented<hash>_<resolved tool name>metric label separately. Runtime metric labels and dependency requirements stay unchanged.Verification with freshly upgraded dependencies on Python 3.14:
c6878eca53235d1e43e469ce2ae3b26cb01a12e6, including Python 3.11–3.15, both free-threaded entries, all 23 configured floor entries, isolated extra installs, lint, links, and docs.Current resolved dependency versions include FastMCP/fastmcp-slim 4.2.0, MCP 2.3.0, Starlette 1.10.0, Instrumentator 8.1.0, and Sentry SDK 2.75.0.