Repository navigation
Conversation
BoringSSL is updating SSL_get_ciphers and SSL_CTX_get_ciphers to return const STACK_OF(SSL_CIPHER)* instead of a non-const pointer. Declare the local ciphers variable in SSLPointer::getCiphers as const so it builds cleanly against both OpenSSL and BoringSSL. Refs: https://crbug.com/550501994 Signed-off-by: Lily Chen <[email protected]>
nodejs-github-bot
added
dependencies
Collaborator
|
Review requested:
|
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
panva
approved these changes
Nov 13, 2026
panva
added
author ready
github-actions
Bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
pimterry
approved these changes
Nov 13, 2026
jasnell
approved these changes
Nov 14, 2026
jasnell
added
the
request-ci
panva
removed
the
request-ci
Collaborator
panva
added
the
resume-ci
github-actions
Bot
removed
the
resume-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BoringSSL is updating SSL_get_ciphers and SSL_CTX_get_ciphers to return const STACK_OF(SSL_CIPHER)* instead of a non-const pointer. Declare the local ciphers variable in SSLPointer::getCiphers as const so it builds cleanly against both OpenSSL and BoringSSL.
Refs: https://crbug.com/550501994