Repository navigation
docs: kiro-cli X-Amz-Target evidence and kiro-cps route - #14
Merged
Merged
Conversation
Ran: validate_manifests.py --root deploy/k8s (all pass), test_validate_manifests.py (10 ok), ap-core loader parse of the shipped identity.toml on macmini (ok, throwaway test not committed). No Rust code changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports two findings from the closed phase1-k8s branch (PR #10) onto main.
C: X-Amz-Target evidence. New
docs/evidence/xamz-target.md: kiro-cli 3.3.0 sends exactly oneX-Amz-Targetper call; the model call isAmazonCodeWhispererStreamingService.GenerateAssistantResponse. Captured against a local listener with a surrogate key, 0 real requests. The file lists what is not verified. The open condition indocs/design/phase1.mdis ticked, anddocs/recipes/kiro-cli.mdnotes other targets on cps and codewhisperer. No shipped policy usesaws_targetsfor them; the cps grant has none.D: kiro-cps route.
deploy/k8s/identity-configmap.yamlgets routekiro-cps(hostmanagement.us-east-1.kiro.dev,pass_headers = ["tokentype"]as krs), the credential's route list, and a grant (POST,/). Host list updated in the recipe.Unmeasured: the host was observed by DNS/SNI only (CONNECT logging, kiro-cli 3.3.0, no real request).
tokentypeneed and the error shape are not measured; both are copied from krs and flagged as assumptions in the recipe and the configmap comment. Other-regionmanagement.*hosts are not covered.Checks:
deploy/k8s/validate_manifests.py --root deploy/k8sall pass;test_validate_manifests.py10 ok (it does not count routes, no change needed); the shipped identity.toml loads throughap_core::config::load(checked on macmini with a throwaway test, not committed). No Rust changes, so the cargo CI steps are unaffected.