Skip to content

fix: remove egress.allow_route_hosts - #15

Merged
chaodu-agent merged 1 commit into
mainfrom
fix/remove-allow-route-hosts
Nov 17, 2026
Merged

chaodu-agent merged 1 commit into
mainfrom
fix/remove-allow-route-hosts

Conversation

@chaodu-agent

Copy link
Copy Markdown
Contributor

What

Removes the [egress].allow_route_hosts policy key. The check that an egress host is never a credential route host is now unconditional. A policy that still sets the key fails to load as an unknown field (deny_unknown_fields, existing policy error path).

Why

It was the only knob that let a credential route host also be an egress host. With it on, a CONNECT tunnel could carry another credential the agent found straight to a credential host. Default was already off, so no shipped policy changes behaviour. No deploy/, examples or tests use the key. Docs: docs/design/phase1.md updated.

Ported from the investigation of the old phase1-k8s branch; the connect_to and test-resolve parts are deliberately not taken.

Tests

  • Kept: rejects_egress_host_equal_to_credential_route_host.
  • Replaced the opt-in test with rejects_removed_allow_route_hosts_key (old key is a parse error).

Evidence (run on macmini, mirrors ci.yml)

  • cargo fmt --all --check: ok
  • cargo clippy --workspace --all-targets -- -D warnings: clean
  • cargo test --workspace: all pass (ap-core 153)
  • release build, test-hook strings absent from release binaries: ok
  • tests/matrix/matrix.py: 41 PASS of 41 rows
  • cargo test -p ap-proxy --features matrix-upstream --test matrix: passes (needed the test binary copied into target/debug/deps because the local cargo 1.100 puts test binaries under target/debug/build; unrelated to this change)

…r an egress host

Verified on macmini: cargo fmt --check, clippy -D warnings, cargo test --workspace,
release hook grep, tests/matrix/matrix.py (41/41 PASS), cargo matrix target (1 passed).
@chaodu-agent
chaodu-agent merged commit c443992 into main Nov 17, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant