Repository navigation
fix: remove egress.allow_route_hosts - #15
Merged
Merged
Conversation
…r an egress host Verified on macmini: cargo fmt --check, clippy -D warnings, cargo test --workspace, release hook grep, tests/matrix/matrix.py (41/41 PASS), cargo matrix target (1 passed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
[egress].allow_route_hostspolicy key. The check that an egress host is never a credential route host is now unconditional. A policy that still sets the key fails to load as an unknown field (deny_unknown_fields, existing policy error path).Why
It was the only knob that let a credential route host also be an egress host. With it on, a CONNECT tunnel could carry another credential the agent found straight to a credential host. Default was already off, so no shipped policy changes behaviour. No deploy/, examples or tests use the key. Docs:
docs/design/phase1.mdupdated.Ported from the investigation of the old phase1-k8s branch; the
connect_toandtest-resolveparts are deliberately not taken.Tests
rejects_egress_host_equal_to_credential_route_host.rejects_removed_allow_route_hosts_key(old key is a parse error).Evidence (run on macmini, mirrors ci.yml)
cargo fmt --all --check: okcargo clippy --workspace --all-targets -- -D warnings: cleancargo test --workspace: all pass (ap-core 153)tests/matrix/matrix.py: 41 PASS of 41 rowscargo test -p ap-proxy --features matrix-upstream --test matrix: passes (needed the test binary copied into target/debug/deps because the local cargo 1.100 puts test binaries under target/debug/build; unrelated to this change)