Repository navigation
Conversation
Signed-off-by: g4lb <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@csmarchbanks, each
inc(),dec(),set()andobserve()call runs_raise_if_not_observable(). This change puts the condition of_is_observable()directly in that method, so each update does one less method call. The output and the error do not change.Counter.inc()labels(...).inc()Gaugechildinc()andset()Histogram.observe()Summary.observe()These numbers are from CPython 3.13. CPython 3.10 and 3.14 show the same direction:
Counter.inc()is 12.9% and 15.9% faster. I measured no slowdown on exposition, parsing,labels()and metric creation. I used 20 interleaved rounds and a Mann-Whitney test (Apple M5). On PyPy 3.11, the change is within the noise. Import time did not change (25 rounds). I did not measure other architectures.Checks:
pytestpasses on CPython 3.10, 3.13 and 3.14, and on PyPy 3.11.flake8,isortandmypypass with the tox settings.