Skip to content

Support dark mode on release dashboard - #832

Merged
encukou merged 4 commits into
python:mainfrom
hugovk:dark-dash
Nov 12, 2026
Merged

encukou merged 4 commits into
python:mainfrom
hugovk:dark-dash

Conversation

@hugovk

@hugovk hugovk commented Nov 12, 2026

Copy link
Copy Markdown
Member

Before

With https://buildbot.python.org/#/settings set to dark theme (and OS also to dark):

image

And light:

image

https://buildbot.python.org/#/release_status

Standalone always light:

image

https://buildbot.python.org/release-status

After

As part of app, follows the setting:

image image

As standalone, doesn't access the setting, follows the OS/browser's prefers-color-scheme:

image

OS set to light:

image

@hugovk
hugovk marked this pull request as draft November 12, 2026 13:18
@hugovk

hugovk commented Nov 12, 2026

Copy link
Copy Markdown
Member Author

I'll push a couple more little fixes.

Comment thread master/custom/static/dashboard.css Resolved
@hugovk
hugovk marked this pull request as ready for review November 12, 2026 13:44
Comment on lines 278 to 281
--success-color: #4CAF60;
--warning-color: #C2870F;
--warning-color-bg: #E4B615; /* nicer "traffic light" amber , but not enough contrast for text */
--danger-color: #f44336;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are official Buildbot colours, should we switch to them?

Suggested change
--success-color: #4CAF60;
--warning-color: #C2870F;
--warning-color-bg: #E4B615; /* nicer "traffic light" amber , but not enough contrast for text */
--danger-color: #f44336;
--success-color: var(--bs-success);
--warning-color: var(--bs-warning);
--danger-color: var(--bs-danger);

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're in the Bootstrap CSS that's available for the app but not the standalone page.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. To me the colours look too bright for dark mode, but, I don't use dark mode often. If you're happy with it, let's ship it!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can always adjust later after more eyeballs.

(I don't have merge permissions here.)

Comment thread master/custom/static/dashboard.css Resolved
@encukou
encukou merged commit 81a6a74 into python:main Nov 12, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants