Repository navigation
[WIP] Fix failing GitHub Actions job for mypyc tests - #22489
Closed
hauntsaninja wants to merge 2 commits into
Closed
hauntsaninja wants to merge 2 commits into
hauntsaninja wants to merge 2 commits into
Conversation
Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Copilot stopped work on behalf of
hauntsaninja due to an error
November 15, 2026 08:37
cdce8p
reviewed
Nov 15, 2026
| sudo apt-get install -q -y --no-install-recommends \ | ||
| build-essential gdb lcov libbz2-dev libffi-dev libgdbm-dev liblzma-dev libncurses5-dev \ | ||
| libreadline6-dev libsqlite3-dev libssl-dev lzma lzma-dev tk-dev uuid-dev zlib1g-dev | ||
| libreadline6-dev libsqlite3-dev libssl-dev tk-dev uuid-dev zlib1g-dev |
Collaborator
There was a problem hiding this comment.
Suggested change
| libreadline6-dev libsqlite3-dev libssl-dev tk-dev uuid-dev zlib1g-dev | |
| libreadline6-dev libsqlite3-dev libssl-dev lzma liblzma-dev tk-dev uuid-dev zlib1g-dev |
lzma-dev is only available up until ubuntu-24.04. The replacement for it is liblzma-dev. I'd also suggest to pin the OS version to ubuntu-26.04 for that job so it doesn't fail accidentally if for some reason a runner still uses the old 24.04 image.
Btw: Even the cpython dev guide still references the "old" dependency if you like to upgrade that, too. https://devguide.python.org/getting-started/setup-building/#install-dependencies -> Linux -> Ubuntu
| sudo apt-get install -q -y --no-install-recommends \ | ||
| build-essential gdb lcov libbz2-dev libffi-dev libgdbm-dev liblzma-dev libncurses5-dev \ | ||
| libreadline6-dev libsqlite3-dev libssl-dev lzma lzma-dev tk-dev uuid-dev zlib1g-dev | ||
| libreadline6-dev libsqlite3-dev libssl-dev tk-dev uuid-dev zlib1g-dev |
Collaborator
There was a problem hiding this comment.
Suggested change
| libreadline6-dev libsqlite3-dev libssl-dev tk-dev uuid-dev zlib1g-dev | |
| libreadline6-dev libsqlite3-dev libssl-dev lzma liblzma-dev tk-dev uuid-dev zlib1g-dev |
Collaborator
Author
|
uuuugh i accidentally clicked the copilot button while looking at #22488 and tried to hit stop on it, didn't know it would go and create this PR. i'll incorporate your suggestions in my actual PR though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.