Repository navigation
Fix chunk attachments in sublevels not saving - #1662
Merged
Merged
Conversation
ryanhcode
approved these changes
Nov 13, 2026
ryanhcode
left a comment
Owner
There was a problem hiding this comment.
Thank you for your contribution!
super-original
pushed a commit
to super-original/sable
that referenced
this pull request
Nov 13, 2026
Fix for ryanhcode#1504 Chunk attachments in sublevels are not saved properly, so they do not appear when reloading a sublevel. They are being saved to the main sublevel data tag, instead of the chunk specific tag. The loading code expects the attachments to be on the chunk tag, so they are never loaded in. This just changes it to save them in the correct location.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #1504
Chunk attachments in sublevels are not saved properly, so they do not appear when reloading a sublevel. They are being saved to the main sublevel data tag, instead of the chunk specific tag. The loading code expects the attachments to be on the chunk tag, so they are never loaded in. This just changes it to save them in the correct location.