Skip to content

ci: fail the notify job when the announcement is rejected - #1623

Merged
zimeg merged 1 commit into
mainfrom
notify-errors-true
Nov 14, 2026
Merged

zimeg merged 1 commit into
mainfrom
notify-errors-true

Conversation

@zimeg

@zimeg zimeg commented Nov 13, 2026

Copy link
Copy Markdown
Member

Summary

This pull request sets errors: true on the release announcement step, so a webhook that rejects the post fails the notify job instead of logging an error and staying green.

         uses: slackapi/slack-github-action@dcb1066f776dd043e64d0e8ba94ca15cc7e1875d # v4.0.0
         with:
+          errors: true
           webhook: ${{ secrets.SLACK_RELEASE_ANNOUNCEMENTS_WEBHOOK_URL }}

Testing

  • On the next release, confirm the announcement posts and the notify job stays green.

Category

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

🤖 Generated with Claude Code

@zimeg
zimeg requested a review from a team as a code owner November 13, 2026 23:58
@zimeg zimeg added this to the next milestone Nov 13, 2026
@zimeg zimeg added the github_actions Pull requests that update GitHub Actions code label Nov 13, 2026
@zimeg zimeg self-assigned this Nov 13, 2026
@codecov

codecov Bot commented Nov 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.57%. Comparing base (f1390d7) to head (ba4dcb1).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1623   +/-   ##
=======================================
  Coverage   91.57%   91.57%           
=======================================
  Files         228      228           
  Lines        7285     7285           
=======================================
  Hits         6671     6671           
  Misses        614      614           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@mwbrooks mwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thanks @zimeg! Good to have a revoked webhook show up as a red notify job here, same as the other split-notify repos.

@zimeg

zimeg commented Nov 14, 2026

Copy link
Copy Markdown
Member Author

⚡ Thanks for the kind review @mwbrooks! Bolt announcements join the fail-loud club 🔔

@zimeg
zimeg merged commit 1ab319e into main Nov 14, 2026
17 checks passed
@zimeg
zimeg deleted the notify-errors-true branch November 14, 2026 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants