Skip to content

UAOL: lifty the narrow format support on the Deep Buffer PCMs - #11483

Open
ujfalusi wants to merge 2 commits into
thesofproject:mainfrom
ujfalusi:peter/pr/uaol-more-formats-for-db
Open

ujfalusi wants to merge 2 commits into
thesofproject:mainfrom
ujfalusi:peter/pr/uaol-more-formats-for-db

Conversation

@ujfalusi

Copy link
Copy Markdown
Contributor

Allow the same range of formats to be supported via the Deep Buffer UAOL PCMs as we support via the normal ones.

This change uncovered an issue that if we have 192KHz or higher sampling rate than the host buffer size will increase beyond 65,535 bytes, which is the limit for the DGMBS HDA register and this has not been checked, resulting mixer underruns when using high sampling rate (or more channels).

Large deep-buffer requests can exceed the range of the HDA gateway
minimum-buffer-size register. Cap the preferred allocation at UINT16_MAX
rounded down to a whole DMA allocation unit, and reject configurations
whose minimum buffer already exceeds that limit.

Keep non-HDA DMA allocation unchanged and use the actual allocated size
for the existing DMA setup.

Signed-off-by: Peter Ujfalusi <[email protected]>
Apply the UAOL input formats and S32 internal formats to both
deep-buffer playback pipelines, and advertise the same PCM channel and
rate capabilities as normal playback.

Calculate the minimum host buffer size from the configured minimum rate
rather than a fixed 48 kHz, and update the mixer compatibility
description.

Signed-off-by: Peter Ujfalusi <[email protected]>
Copilot AI balanced review requested due to automatic review settings November 18, 2026 10:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The supplied review evidence identifies no active issues requiring changes.

No open issues 🎉

What changed in this PR

This PR expands UAOL deep-buffer PCM support to match normal playback and limits HDA DMA buffer sizes to avoid exceeding the 16-bit DGMBS register limit.

Changes:

  • Enable the shared UAOL formats, rates, and channel ranges in both deep-buffer pipelines.
  • Calculate minimum PCM buffer sizes using the minimum supported rate and channel count.
  • Cap HDA DMA buffers at aligned sizes within 65,535 bytes, rejecting configurations whose minimum allocation exceeds that limit.
File Description
tools/​topology/​topology2/​platform/​intel/​uaol-generic.conf Update comments to describe matching playback capabilities and mixer requirements.
tools/​topology/​topology2/​platform/​intel/​uaol-deep-buffer1.conf Expand the second deep-buffer PCM’s capabilities and adjust minimum buffer sizing.
tools/​topology/​topology2/​platform/​intel/​uaol-deep-buffer.conf Expand the first deep-buffer PCM’s capabilities and adjust minimum buffer sizing.
src/​audio/​host-zephyr.c Enforce the HDA DMA buffer limit while preserving allocation alignment.

Review effort: Balanced

@intel-sofci

Copy link
Copy Markdown

PR 11483: test results

Run date: 2026-11-18 10:45 UTC

Tested commit: 0a2184a2e0ce7218c422baa16a194fd624a5c445

mtl pass rate lnl pass rate ptl pass rate wcl pass rate nvl pass rate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants