Repository navigation
kernel/user partition, Phase 4 part 6: move kernel-only headers to sof/kernel #11487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
lgirdwood
wants to merge
7
commits into
thesofproject:main
Choose a base branch
from
lgirdwood:kernel-user/phase4f
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6090cb7
kernel: add src/kernel/include for the kernel-only headers
lrgirdwo 11c5d98
platform: move sof/platform.h to sof/kernel/platform.h
lrgirdwo de46649
ipc: move sof/ipc/driver.h to sof/kernel/ipc/driver.h
lrgirdwo 2df116f
library_manager: move sof/llext_manager.h to sof/kernel/llext_manager.h
lrgirdwo 7086a38
drivers: move the sof/drivers headers to sof/kernel/drivers
lrgirdwo ec0eb0b
lib: move regions_mm.h and vpage.h to sof/kernel/lib
lrgirdwo ac4bbad
drivers: remove the unused dmic.h and pmc.h
lrgirdwo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking (
doxygenCI failure): Updating these@reftargets (plus line 235 forplatform.h) fails in CI becausedoc/sof.doxygen.indoes not list@top_srcdir@/src/kernel/include/sofinINPUT:Note that once
@top_srcdir@/src/kernel/include/sofis added toINPUT, Doxygen also flags the stale@filepaths in the two pure-rename headers from commit 7 (WARN_AS_ERROR = FAIL_ON_WARNINGS):src/kernel/include/sof/kernel/lib/regions_mm.h:9: change@file sof/lib/regions_mm.h->@file sof/kernel/lib/regions_mm.hsrc/kernel/include/sof/kernel/lib/vpage.h:5: change@file sof/lib/vpage.h->@file sof/kernel/lib/vpage.hApplying all three makes
ninja -C docbuild docpass cleanly.