Skip to content

feat(autoware): Add PointCloud struct - #802

Open
romancardenas wants to merge 2 commits into
tier4:mainfrom
romancardenas:autoware/point_cloud
Open

romancardenas wants to merge 2 commits into
tier4:mainfrom
romancardenas:autoware/point_cloud

Conversation

@romancardenas

Copy link
Copy Markdown
Contributor

Description

This is part of #748.

This PR builds on top of #801.

It addresses @nokosaaan 's comments in #783. The idea is trying to get an alternative implementation that avoids allocations in the heap. I will divide the contribution in several PRs, as it will ease the review process.

This PR adds the PointCloud structure. Unlike in ROS2's autoware, the message fields are private, and fields are checked at construction time to avoid overflows.

The structure itself contains multiple convenience methods to access to and iterate over points.

How was this PR tested?

  • scripts/ci.sh passes on my machine.
  • Unit tests of the new module pass on my machine

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant