Skip to content

Fix mistyped identifiers - #28

Merged
vtrlx merged 1 commit into
vtrlx:masterfrom
jaapschouwenburg:bad-globals
Nov 17, 2026
Merged

vtrlx merged 1 commit into
vtrlx:masterfrom
jaapschouwenburg:bad-globals

Conversation

@jaapschouwenburg

@jaapschouwenburg jaapschouwenburg commented Nov 10, 2026 •

Copy link
Copy Markdown

Replace unset globals in package.ensure and Gtk3.Assistant:add with the intended variable and method argument.

The first issue causes the version comparison in ensure, if performed, to raise an error. The second prevents the path of adding a page to an Assistant without wrapping it in a table from succeeding.

Replace unset globals in package.ensure and Gtk3.Assistant:add with the
intended variable and method argument.
@vtrlx

vtrlx commented Nov 17, 2026

Copy link
Copy Markdown
Owner

Beautiful. Thank you.

Don't mind the CI failures. That's due to some GLib changes that have now landed in current Ubuntu LTS. The CI is failing because it is testing old behaviour, and not the current (correct) ones.

@vtrlx
vtrlx merged commit 82f3dc8 into vtrlx:master Nov 17, 2026
8 of 18 checks passed
@jaapschouwenburg
jaapschouwenburg deleted the bad-globals branch November 17, 2026 17:04
@jaapschouwenburg

Copy link
Copy Markdown
Author

I didn’t think it could be anything I did, but that’s still a relief 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants