Repository navigation
Remove Coveralls - #38
Merged
Merged
Conversation
Every matrix job uploaded its coverage to the same Coveralls build, and the job that finished first closed it, so the upload failed for another job with 'Can't add a job to a build that is already closed'. Drop the upload step, the clover file only the upload needed and the badge. The text coverage report stays in the log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every matrix job uploaded its coverage to the same Coveralls build, and the job that finished first closed it. Another job then failed with
422 Can't add a job to a build that is already closed, although its tests had passed, and re-running that job cannot succeed because the build stays closed. With the seven jobs of #33 this happens more often. The maintainer decided to drop Coveralls instead of fixing the upload.The text coverage report stays in the job log. The Clover file is no longer written, because only the upload used it.
Evidence
Tests (PHP 7.4)failed in the stepUpload coverage results to Coverallson the branch of Add Roave Backward Compatibility Check to CI #37, with the tests green (run).After: the step is gone; see the checks of this pull request.
Merge Danger
Door: two-way
Blast Radius: CI and README only
The repository's Coveralls integration is not touched; it can be removed in the Coveralls settings.