Skip to content

Remove Coveralls - #38

Merged
Art4 merged 1 commit into
masterfrom
remove-coveralls
Nov 21, 2026
Merged

Art4 merged 1 commit into
masterfrom
remove-coveralls

Conversation

@Art4

@Art4 Art4 commented Nov 21, 2026

Copy link
Copy Markdown
Member

Summary

 .github/workflows/php.yml
-    - name: Upload coverage results to Coveralls
-      ... php-coveralls --coverage_clover=build/logs/clover.xml -v
-    vendor/bin/phpunit --coverage-text --coverage-clover build/logs/clover.xml
+    vendor/bin/phpunit --coverage-text
 README.md
-    [![Coverage Status](https://coveralls.io/...)]

Every matrix job uploaded its coverage to the same Coveralls build, and the job that finished first closed it. Another job then failed with 422 Can't add a job to a build that is already closed, although its tests had passed, and re-running that job cannot succeed because the build stays closed. With the seven jobs of #33 this happens more often. The maintainer decided to drop Coveralls instead of fixing the upload.

The text coverage report stays in the job log. The Clover file is no longer written, because only the upload used it.

Evidence

Merge Danger

Door: two-way

Blast Radius: CI and README only

The repository's Coveralls integration is not touched; it can be removed in the Coveralls settings.

Every matrix job uploaded its coverage to the same Coveralls build, and the job that finished first closed it, so the upload failed for another job with 'Can't add a job to a build that is already closed'. Drop the upload step, the clover file only the upload needed and the badge. The text coverage report stays in the log.
@Art4
Art4 merged commit 1a9912f into master Nov 21, 2026
2 checks passed
@Art4
Art4 deleted the remove-coveralls branch November 21, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant