Repository navigation
fix(statements): parser and finance review follow-ups (#57) - #245
Conversation
- TCB: a time label anywhere on the period row or a row above the table with a time (Giờ/Time: 08:00 - 14:30, Khung giờ, Khoảng thời gian), ranges with ~ to → / , and cells after a print time make the export partial; whole-day ranges (00:00 - 23:59) and 12:00 AM / 11:59 PM are whole days. - /admin/statements: campaigns whose trust a rejection blocks, with a restore action (restore_campaign_statement_trust, note required); amount fields take 9.999.999.999.999 VND. Needs DOS.Me migration 20261122100000_give_statement_review_followups. Co-Authored-By: Claude Opus 5.5 <[email protected]>
There was a problem hiding this comment.
If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.
Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
… states a failed read (#245 review) - TCB: rows above the table are checked whole. After the period's own dates (and the times read with them in their cells), print/export times, bare dates and exact whole-day ranges are taken out, any time left (hour-only, 14.30, 8 giờ, 2 PM...) makes the export partial. A time in a cell after the to-date is no longer read as the period's end time. - listTrustBlocks returns null on a failed read; the page says so instead of 'none blocked'. Restore message no longer promises automatic uploads. - Tests: every probe of the review, the action's role and note limits. Co-Authored-By: Claude Opus 5.5 <[email protected]>
…h colons (#245 review) Co-Authored-By: Claude Opus 5.5 <[email protected]>
…via the server with the actor (#245) Co-Authored-By: Claude Opus 5.5 <[email protected]>
⏸️ DOS Review: Automatic Review Limit ReachedDOS Code Review already reviewed 3 commits of this pull request automatically, the limit for one pull request, so this commit was not reviewed automatically and nothing was charged. Please step back before pushing another fix: a pull request that needs this many review rounds usually needs a rethink of its approach or a smaller scope, not one more patch. When you are ready, a maintainer can comment /review to review the current commit. |
…a time (#245) Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
PO acceptance: merge at 040f877. Money second review: no blocker; all earlier parser bypasses now partial; restore action authorized correctly (session, UUID/int/note validation, is_admin with user token, service RPC with session actor). Remaining: comma-before-time and footer-row bypasses go to a small follow-up; false refusals of names/addresses with time-like text are checked against JOY's real Techcombank samples. DOS Code Review shows its round cap. DOS/DOS.Me#1774 merged first. |
Refs #57
Follow-up to #243 (merged as eca23dc): the should-fix items of the PO's Money review, app part. The database part is DOS/DOS.Me (migration
20261122100000_give_statement_review_followups), which must reach a database first. Until then the blocks list reads empty. The Give Product Owner merges.Partial exports the Techcombank Business parser still took as full
After review, the checks are fail-closed. Every row above the table is read whole. The rule removes:
Any time left (hour-only, 14.30, 8 giờ, AM/PM, full-width colons) makes the file partial. A time is never read across cells as the period's end. Names such as "3H" or "4G" also read as a time, which refuses a full file: that is the fail-closed choice.
The first version of this PR checked these items one by one:
~,to,→,/, besides-,–,—and "đến".Finance review
/admin/statementsgets a section "Chiến dịch bị chặn tin cậy sao kê". It lists campaigns whose trust a rejected row blocks (statement_trust_blocks), each with a "Khôi phục tin cậy" form (note required) that callsrestore_campaign_statement_trust. The role is checked first with the user's own token.Review record
A fresh-context subagent reviewed this over three rounds, with probe files of over 140 inputs. Round 1 found 5 MUST_FIX (whole-day lookalikes, unlabelled or hour-only times, print-label skips) and SHOULD_FIX items. Round 2 found print-value ranges and address false refusals. Round 3 found no MUST_FIX; its two remaining false refusals were fixed in 80bfc63.
Checks
🤖 Generated with Claude Code