Repository navigation
Release v2.0.4 - #343
Merged
Merged
Release v2.0.4#343
Conversation
…rom their own directories makePathsRelative cut every path at its first 'vendor' segment, so migrations under api/extensions/vendor resolved to core's vendor directory and were skipped, and a path-linked package outside the app became an absolute --path that Laravel prefixed with the base path. Strip the base path instead and migrate anything outside it with --realpath.
…-paths fix(sandbox): migrate extensions-project and path-linked extensions from their own directories
The coverage gate failed on release/v2.0.4 because every MigrateSandbox test overrode applicationBasePath(). Probe it through a namespaced base_path shim, as the file already does for Fleetbase\Support.
test(sandbox): cover the default application base path
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #343 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 9961 9964 +3
===========================================
Files 532 532
Lines 30371 30374 +3
===========================================
+ Hits 30371 30374 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release PR for
v2.0.4. Merging it intomaintagsv2.0.4throughrelease.yml.What's in it
composer.jsonandRELEASE.md.sandbox:migratenow runs the migrations of extensions installed outside core'svendordirectory (theapi/extensionsproject and path-linked packages).Merge order
main.After that, fleetbase/fleetbase#754 bumps
fleetbase/core-apito^2.0.4. Its Fresh MySQL Migrate job fails without this ("fleetbase_sandbox has no spatial columns").