Skip to content

fix(sandbox): migrate extensions-project and path-linked extensions from their own directories - #342

Merged
roncodes merged 1 commit into
release/v2.0.4from
fix/sandbox-migrate-extensions-paths
Nov 19, 2026
Merged

roncodes merged 1 commit into
release/v2.0.4from
fix/sandbox-migrate-extensions-paths

Conversation

@roncodes

Copy link
Copy Markdown
Member

sandbox:migrate turned each extension's migration directory into a relative path by cutting it at the first vendor segment. That breaks in two cases:

What changed:

  • Paths inside the base path are now made relative by stripping the base path.
  • Paths outside it stay absolute and are migrated with --realpath.
  • Core's own vendor/fleetbase/core-api/migrations is unchanged.

Tests: tests/Unit/Console/MigrateSandboxCommandTest.php passes (6 cases), including a new case for both layouts.

Needs a v2.0.4 tag before fleetbase/fleetbase#754 can bump to it.

…rom their own directories

makePathsRelative cut every path at its first 'vendor' segment, so migrations under
api/extensions/vendor resolved to core's vendor directory and were skipped, and a
path-linked package outside the app became an absolute --path that Laravel prefixed
with the base path. Strip the base path instead and migrate anything outside it with
--realpath.
@roncodes
roncodes changed the base branch from main to release/v2.0.4 November 19, 2026 10:08
@roncodes roncodes mentioned this pull request Nov 19, 2026
@roncodes
roncodes merged commit d1dfa70 into release/v2.0.4 Nov 19, 2026
4 of 5 checks passed
@roncodes
roncodes deleted the fix/sandbox-migrate-extensions-paths branch November 19, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant