Repository navigation
fix(sandbox): migrate extensions-project and path-linked extensions from their own directories - #342
Merged
Conversation
…rom their own directories makePathsRelative cut every path at its first 'vendor' segment, so migrations under api/extensions/vendor resolved to core's vendor directory and were skipped, and a path-linked package outside the app became an absolute --path that Laravel prefixed with the base path. Strip the base path instead and migrate anything outside it with --realpath.
Merged
This was referenced Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sandbox:migrateturned each extension's migration directory into a relative path by cutting it at the firstvendorsegment. That breaks in two cases:api/extensions/vendor/fleetbase/fleetops-api/...becamevendor/fleetbase/fleetops-api/..., which is core's vendor directory, so Fleet-Ops' sandbox migrations never ran. The fresh-migrate CI job on feat(api): installed extensions in their own Composer project (api/extensions) fleetbase#754 fails with "fleetbase_sandbox has no spatial columns".packages/<name>, outsideapi): with novendorsegment, the absolute path was passed as--path, and Laravel prefixes the base path to it.What changed:
--realpath.vendor/fleetbase/core-api/migrationsis unchanged.Tests:
tests/Unit/Console/MigrateSandboxCommandTest.phppasses (6 cases), including a new case for both layouts.Needs a v2.0.4 tag before fleetbase/fleetbase#754 can bump to it.